Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(error): handle 504 timeout error with snackbar (DEV-751) #739

Merged
merged 2 commits into from May 16, 2022

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented May 13, 2022

resolves DEV-751

@kilchenmann kilchenmann self-assigned this May 13, 2022
@kilchenmann kilchenmann added enhancement New feature or request refactor Refactor or redesign labels May 13, 2022
@kilchenmann kilchenmann requested a review from mdelez May 13, 2022
@kilchenmann
Copy link
Contributor Author

kilchenmann commented May 13, 2022

Screen Shot 2022-05-13 at 16 55 57

In case of 504 timeout error, the notification service opens the snackbar message without duration. The error will be stay until the user closes it. The message contains the url where the request failed. But in most of the time, the url is not helpful information especially when it was a request with payload (e.g. http://0.0.0.0:3333/v2/searchextended/count).

@kilchenmann
Copy link
Contributor Author

kilchenmann commented May 13, 2022

@mdelez in DEV-751 you'll find an instruction to reproduce a "slow" api to enforce a timeout error; if you want to test this PR.

@kilchenmann kilchenmann requested a review from Vijeinath May 16, 2022
Copy link
Contributor

@Vijeinath Vijeinath left a comment

Looks fine to me!

@kilchenmann kilchenmann merged commit 8f6c409 into main May 16, 2022
13 checks passed
@kilchenmann kilchenmann deleted the wip/dev-751-timeout-error-handling branch May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Refactor or redesign
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants