Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(representation)!: new navigation in still-image viewer (DEV-895) #742

Merged
merged 4 commits into from May 17, 2022

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented May 17, 2022

resolves DEV-895

@kilchenmann kilchenmann self-assigned this May 17, 2022
@kilchenmann kilchenmann added enhancement New feature or request styling Update style; no production code change labels May 17, 2022
@kilchenmann kilchenmann requested a review from Vijeinath May 17, 2022
<button mat-icon-button (click)="openReplaceFileDialog()" class="replace-file" matTooltip="Replace video file" [matTooltipPosition]="matTooltipPos">
<mat-icon>cloud_upload</mat-icon>
</button>
<button mat-icon-button (click)="toggleCinemaMode()"
[matTooltip]="(cinemaMode ? 'Default view' : 'Cinema mode')" [matTooltipPosition]="matTooltipPos">
Copy link
Contributor

@Vijeinath Vijeinath May 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe using the same word for consistent phrasing-> 'Default mode' & 'Cinema mode' OR 'Default view' & 'Cinema view'

Copy link
Contributor

@Vijeinath Vijeinath left a comment

All good

@kilchenmann kilchenmann merged commit dbc75ff into main May 17, 2022
13 checks passed
@kilchenmann kilchenmann deleted the wip/dev-895-osd-redesign branch May 17, 2022
@daschbot daschbot mentioned this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request styling Update style; no production code change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants