Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(resource): display incoming links the same way as prop values (DEV-567) #747

Merged
merged 1 commit into from May 19, 2022

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented May 19, 2022

resolves DEV-567

@kilchenmann kilchenmann self-assigned this May 19, 2022
@kilchenmann kilchenmann added enhancement New feature or request chore Maintenance and build tasks labels May 19, 2022
@kilchenmann kilchenmann requested a review from Vijeinath May 19, 2022
@@ -101,7 +101,7 @@ <h3 class="label mat-title">
<!-- list of properties -->
<div *ngFor="let prop of resource.resProps; let last = last">
<!-- show property; all in case of showAll === true or only the ones with prop.values -->
<div *ngIf="(showAllProps || ( prop.values && prop.values.length > 0 )) && (
<div *ngIf="(showAllProps || ( prop.values && prop.values.length > 0 ) || (prop.propDef.id === hasIncomingLinkIri && incomingLinkResources.length > 0)) && (
Copy link
Contributor

@Vijeinath Vijeinath May 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a long line for a *ngIf. Is it possible to move this into a function within the typescript file and give the function a meaningful name?

Copy link
Contributor Author

@kilchenmann kilchenmann May 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I know. good idea with the method, but for now I'm not able to spend too much time on small improvements. We need the big features now 😉

Copy link
Contributor

@Vijeinath Vijeinath left a comment

My suggestion is optional as long as the code works

@kilchenmann kilchenmann merged commit 7d2f6f3 into main May 19, 2022
13 checks passed
@kilchenmann kilchenmann deleted the wip/dev-567-display-incoming-links branch May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance and build tasks enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants