Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resource): create new resource instance directly from ontology's class (DEV-959) #755

Merged
merged 6 commits into from Jun 7, 2022

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented May 31, 2022

resolves DEV-959

@kilchenmann kilchenmann marked this pull request as draft May 31, 2022
@kilchenmann kilchenmann self-assigned this May 31, 2022
@kilchenmann kilchenmann added the enhancement New feature or request label May 31, 2022
@kilchenmann kilchenmann marked this pull request as ready for review Jun 7, 2022
@kilchenmann kilchenmann requested a review from mdelez Jun 7, 2022
mdelez
mdelez approved these changes Jun 7, 2022
Copy link
Collaborator

@mdelez mdelez left a comment

works well :) I left a comment but it's up to you if you want to keep or remove the code.

disableClose: true
};

const dialogRef = this._dialog.open(
Copy link
Collaborator

@mdelez mdelez Jun 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't have any future plans for anything happening after the dialog is closed, you don't need to assign this to a const and can remove the logic below for doing something after the dialog is closed. But it's fine if we keep it as well. Maybe we'll need it in the future.

Copy link
Contributor Author

@kilchenmann kilchenmann Jun 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Thanks. But I think I'll keep it for the moment. Just copied from other components.

@kilchenmann kilchenmann merged commit 5f30719 into main Jun 7, 2022
13 checks passed
@kilchenmann kilchenmann deleted the wip/dev-959-new-res-instance branch Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants