Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(overview): add overview and project tile components (DEV-984) #777

Merged
merged 10 commits into from Jul 27, 2022

Conversation

mdelez
Copy link
Collaborator

@mdelez mdelez commented Jul 20, 2022

resolves DEV-984

@mdelez mdelez added the enhancement New feature or request label Jul 20, 2022
@mdelez mdelez self-assigned this Jul 20, 2022
@mdelez mdelez marked this pull request as ready for review Jul 27, 2022
@@ -222,6 +222,11 @@ export class ProjectComponent implements OnInit {
}
}

// go to overview page
Copy link
Contributor

@Vijeinath Vijeinath Jul 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this comment refers to the function its more common to do the "/** [...] */" comment

Copy link
Collaborator Author

@mdelez mdelez Jul 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true true, changed in 2832fce

Copy link
Contributor

@Vijeinath Vijeinath left a comment

LGTM! Just keep in mind that I have never implemented tests in angular.

Copy link
Contributor

@EricSommerhalder EricSommerhalder left a comment

Perfect thanks

@mdelez mdelez merged commit a64359b into main Jul 27, 2022
13 checks passed
@mdelez mdelez deleted the wip/dev-984-new-overview-workflow branch Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants