Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(property-form): App changes "salsah-gui:List" to "salsah-gui:Pulldown" (DEV-1089) #783

Merged
merged 2 commits into from Jul 29, 2022

Conversation

mdelez
Copy link
Collaborator

@mdelez mdelez commented Jul 29, 2022

resolves DEV-1089

The property form currently calls the replaceGuiElement() method any time a label or comment on a property is changed and since salsah-gui:List is no longer supported in the app as of #643, the guiElement of ListValue object types was always changed to salsah-gui:Pulldown. However, in the API (not specifically stated in the docs, see screenshot below), it's only possible to change the guiElement of a TextValue object type so we should only call replaceGuiElement() if the property is a TextValue and the guiElement is different from it's initial value.

screenshot from old Youtrack task:
Screen Shot 2022-07-29 at 10 44 33

@mdelez mdelez added the bug A bug fix label Jul 29, 2022
@mdelez mdelez self-assigned this Jul 29, 2022
@mdelez mdelez marked this pull request as ready for review Jul 29, 2022
@mdelez mdelez requested a review from Vijeinath Jul 29, 2022
Copy link
Contributor

@Vijeinath Vijeinath left a comment

LGTM

@mdelez mdelez merged commit 109ca05 into main Jul 29, 2022
13 checks passed
@mdelez mdelez deleted the wip/dev-1089-fix-gui-element-list-pulldown branch Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants