Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(archive): new archive representation view (DEV-1084) #785

Merged
merged 7 commits into from Aug 3, 2022

Conversation

mdelez
Copy link
Collaborator

@mdelez mdelez commented Jul 29, 2022

resolves DEV-1084

@mdelez mdelez added the enhancement New feature or request label Jul 29, 2022
@mdelez mdelez self-assigned this Jul 29, 2022
@mdelez mdelez marked this pull request as ready for review Aug 3, 2022
<div class="toolbar">
<!-- toolbar -->
<div class="action horizontal bottom">
<!-- vertical more button with menu to downlaod and replace file -->
Copy link
Contributor

@Vijeinath Vijeinath Aug 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the word "vertical" does not make sense for me in this sentence. In the outer div there is "horizontal" written

Copy link
Collaborator Author

@mdelez mdelez Aug 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It refers to the three dots menu which has three vertical dots but I can see how it can be confusing with the "horizontal" class name right above it. I'll clarify the comment.

Copy link
Contributor

@Vijeinath Vijeinath left a comment

LGTM. Can you check your html comment where I added my comment?

@mdelez
Copy link
Collaborator Author

mdelez commented Aug 3, 2022

LGTM. Can you check your html comment where I added my comment?

done in 998546e

@mdelez mdelez merged commit db40310 into main Aug 3, 2022
13 checks passed
@mdelez mdelez deleted the wip/dsp-1084-archive-action-bar branch Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants