Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(document): changes to pdf viewer (DEV-1149) #789

Merged
merged 7 commits into from Aug 5, 2022

Conversation

Vijeinath
Copy link
Contributor

@Vijeinath Vijeinath commented Aug 5, 2022

resolves DEV-1149

@Vijeinath Vijeinath requested a review from mdelez as a code owner Aug 5, 2022
@Vijeinath Vijeinath requested a review from EricSommerhalder Aug 5, 2022
@mdelez mdelez changed the title Wip/dev 1149 changes document feat(document): changes to pdf viewer (DEV-1149) Aug 5, 2022
Copy link
Collaborator

@mdelez mdelez left a comment

Works well, thanks! I just have a small request to add a call to _getOriginalFilename() in the _replaceFile method similar to how it's done in the archive component. This wasn't necessary before because we didn't allow the user to download the file but now we need to ensure the filename is updated when replacing the file.

@mdelez mdelez self-requested a review Aug 5, 2022
mdelez
mdelez approved these changes Aug 5, 2022
@Vijeinath Vijeinath merged commit d39ed14 into main Aug 5, 2022
13 checks passed
@Vijeinath Vijeinath deleted the wip/dev-1149-changes-document branch Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants