Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(projects): changes to nav bar (DEV-1101) #790

Merged
merged 11 commits into from Aug 9, 2022

Conversation

mdelez
Copy link
Collaborator

@mdelez mdelez commented Aug 5, 2022

resolves DEV-1101

@mdelez mdelez added the enhancement New feature or request label Aug 5, 2022
@mdelez mdelez self-assigned this Aug 5, 2022
@mdelez mdelez marked this pull request as ready for review Aug 9, 2022
@mdelez mdelez requested a review from Vijeinath Aug 9, 2022
hideTooltip(elem: HTMLElement): boolean {
return !(elem.scrollHeight > elem.clientHeight);
}
Copy link
Contributor

@Vijeinath Vijeinath Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rename the function because it does not directly do something about tool tip. It compares the height of the elements. So I would use something like "compareHeights" or "checkHeights" or "checkElementHeight" etc.

Copy link
Collaborator Author

@mdelez mdelez Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point! done in 1b17e0b

hideTooltip(elem: HTMLElement): boolean {
return !(elem.scrollHeight > elem.clientHeight);
}
Copy link
Contributor

@Vijeinath Vijeinath Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above about renaming function

Copy link
Collaborator Author

@mdelez mdelez Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in 1b17e0b

Copy link
Contributor

@Vijeinath Vijeinath left a comment

All good, just renaming two functions

@mdelez mdelez requested a review from Vijeinath Aug 9, 2022
@mdelez mdelez merged commit d9570b9 into main Aug 9, 2022
13 checks passed
@mdelez mdelez deleted the wip/dev-1101-labels-cut-off branch Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants