Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ontology): ontology editor read mode (DEV-1183) #799

Merged
merged 6 commits into from Aug 18, 2022

Conversation

mdelez
Copy link
Collaborator

@mdelez mdelez commented Aug 16, 2022

resolves DEV-1183

@mdelez mdelez added the enhancement New feature or request label Aug 16, 2022
@mdelez mdelez self-assigned this Aug 16, 2022
@mdelez mdelez marked this pull request as ready for review Aug 17, 2022
@@ -65,10 +65,11 @@
<mat-expansion-panel [expanded]="first">
<mat-expansion-panel-header>
<div class="sidenav-panel-header"
(click)="projectAdmin ? $event.stopPropagation() : true">
(click)="projectMember ? $event.stopPropagation() : true">
Copy link
Contributor

@Vijeinath Vijeinath Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know that you can just pass a boolean instead of executing a function at a click event

Copy link
Contributor

@Vijeinath Vijeinath left a comment

Looks good

@mdelez mdelez merged commit 02b5a48 into main Aug 18, 2022
12 checks passed
@mdelez mdelez deleted the wip/dev-1183-onto-editor-read-mode branch Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants