Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Reorganise the main menu and the data menu #807

Merged
merged 11 commits into from Sep 9, 2022

Conversation

flavens
Copy link
Contributor

@flavens flavens commented Aug 24, 2022

resolves DEV-1258

@flavens flavens self-assigned this Aug 24, 2022
@@ -35,7 +38,6 @@ theme:
accent: 'deep purple'
features:
- navigation.tabs
- navigation.sections
Copy link
Contributor Author

@flavens flavens Aug 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To display the left side menu with a drop-down, I removed this line. It is the only way I found to do what I wanted.
Open to any other suggestions.

@flavens flavens marked this pull request as ready for review Aug 24, 2022
@flavens flavens requested a review from mdelez as a code owner Aug 24, 2022
@flavens
Copy link
Contributor Author

flavens commented Aug 30, 2022

@mdelez I resolved the conflicts. Possible to review when you can.

docs/user-guide/data/search.md Outdated Show resolved Hide resolved
docs/user-guide/data/search.md Outdated Show resolved Hide resolved
docs/user-guide/data/work-on-data.md Outdated Show resolved Hide resolved
docs/user-guide/data/work-on-data.md Outdated Show resolved Hide resolved
docs/user-guide/data/work-on-data.md Outdated Show resolved Hide resolved
docs/user-guide/data/work-on-data.md Outdated Show resolved Hide resolved
docs/user-guide/data/work-on-data.md Outdated Show resolved Hide resolved
docs/user-guide/data/work-on-data.md Outdated Show resolved Hide resolved
docs/user-guide/data/work-on-data.md Outdated Show resolved Hide resolved
docs/user-guide/data/work-on-data.md Outdated Show resolved Hide resolved
@flavens flavens requested a review from mdelez Aug 31, 2022
Copy link
Collaborator

@mdelez mdelez left a comment

just one small fix and then I will approve

@@ -117,13 +117,13 @@ A "plus" button is displayed to the right of the label or after the first value

![Save or undo the changes.](../../assets/images/add-new-text-value.png)*Save or undo the changes you made.*

If your property is linked to another resource, you can search for an existing value by typing the first letter of the resource label you are looking for. You can also create a new resource instance by clicking on the first option in the drop-down menu, `Create new: xxx`.
If your property is linked to another resource, you can search for an existing value by typing the first three letter of the resource label you are looking for. You can also create a new resource instance by clicking on the first option in the drop-down menu, `Create new: xxx`.
Copy link
Collaborator

@mdelez mdelez Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

letter -> letters

@mdelez mdelez self-requested a review Sep 9, 2022
mdelez
mdelez approved these changes Sep 9, 2022
@mdelez mdelez merged commit f8ef81d into main Sep 9, 2022
11 checks passed
@mdelez mdelez deleted the wip/dev-1258-reorganize-menu branch Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants