Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(upload): use file extensions for valid file types instead of MIME types (DEV-1203) #808

Merged
merged 5 commits into from Sep 1, 2022

Conversation

mdelez
Copy link
Collaborator

@mdelez mdelez commented Aug 26, 2022

resolves DEV-1203

@mdelez mdelez added the refactor Refactor or redesign label Aug 26, 2022
@mdelez mdelez self-assigned this Aug 26, 2022
@mdelez mdelez marked this pull request as ready for review Aug 29, 2022
@mdelez
Copy link
Collaborator Author

mdelez commented Aug 29, 2022

@EricSommerhalder @domsteinbach I changed how we check if a file type is allowed. It now checks the file extension instead of the MIME type. I would be grateful if you could also test this on your end and make sure all the file uploads work. You don't actually need to create a resource instance for each file, just check if the upload works via the upload component when you create a new resource instance.

Here are the test files:
dsp-tools-test-data.zip

Copy link
Contributor

@domsteinbach domsteinbach left a comment

The ordering of the supported types is the only thing I like to address.

Copy link
Contributor

@EricSommerhalder EricSommerhalder left a comment

LGTM

@mdelez mdelez requested a review from domsteinbach Sep 1, 2022
@mdelez mdelez merged commit 448e783 into main Sep 1, 2022
11 checks passed
@mdelez mdelez deleted the wip/dev-1203-clarify-upload-file-types branch Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor or redesign
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants