Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(document): document viewer for non-pdf documents (DEV-1303) #812

Merged
merged 6 commits into from Sep 7, 2022

Conversation

mdelez
Copy link
Collaborator

@mdelez mdelez commented Aug 31, 2022

resolves DEV-1303

requires JS-LIB 7.4.3 to work

@mdelez mdelez added the enhancement New feature or request label Aug 31, 2022
@mdelez mdelez self-assigned this Aug 31, 2022
@mdelez mdelez marked this pull request as ready for review Sep 5, 2022
@@ -157,6 +166,7 @@ export class DocumentComponent implements OnInit, AfterViewInit {

this._http.get(pathToJson, requestOptions).subscribe(
res => {
console.log('res: ', res);
Copy link
Contributor

@Vijeinath Vijeinath Sep 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary to console log?

Copy link
Collaborator Author

@mdelez mdelez Sep 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely not 😅 removed in 1e2e4a3

Copy link
Contributor

@Vijeinath Vijeinath left a comment

Looks good

@mdelez mdelez merged commit 36008c6 into main Sep 7, 2022
11 checks passed
@mdelez mdelez deleted the wip/dev-1303-non-pdf-document-viewer branch Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants