Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resource): compound resource with restricted resources infinite loading (DEV-1114) #813

Merged
merged 2 commits into from Sep 5, 2022

Conversation

mdelez
Copy link
Collaborator

@mdelez mdelez commented Sep 1, 2022

resolves DEV-1114

@mdelez mdelez added the bug A bug fix label Sep 1, 2022
@mdelez mdelez self-assigned this Sep 1, 2022
@mdelez mdelez marked this pull request as ready for review Sep 1, 2022
@mdelez mdelez requested a review from EricSommerhalder Sep 1, 2022
@mdelez
Copy link
Collaborator Author

mdelez commented Sep 1, 2022

@EricSommerhalder it's a one-line fix. The other files are the setup to run the app using the staging server. I think it'll be useful to have the staging-server config in case we need to investigate other issues Lausanne may have.

To test, you can go to these two links while logged out:
This resource will not exist after today as the staging db is reset every night

Actual staging server:
https://admin.staging.dasch.swiss/resource/0118/pf0Ll0c4QeG8Oypb8_0R_A -> endless loading

Local instance connected to staging server via npm run start-with-staging-server:
http://0.0.0.0:4200/resource/0118/pf0Ll0c4QeG8Oypb8_0R_A -> you can see the resource without the image

@mdelez mdelez merged commit 375166a into main Sep 5, 2022
11 checks passed
@mdelez mdelez deleted the wip/dev-1114-resource-infinite-loading branch Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants