Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resource): update resource's label (DSP-1801) #492

merged 2 commits into from Aug 2, 2021


Copy link

resolves DSP-1801

Copy link
Contributor Author

There are two issues which can't be resolved right now. Both are described in the Youtrack's task:

@kilchenmann kilchenmann self-assigned this Jul 27, 2021
@kilchenmann kilchenmann added the enhancement New feature or request label Jul 27, 2021
@kilchenmann kilchenmann requested a review from mdelez July 27, 2021 06:18
Copy link
Contributor Author

@mdelez what should we do with the two issues mentioned in previous comment? In second case it needs an update of the API or should I do a second request to get the necessary information? Any suggestions?

@kilchenmann kilchenmann marked this pull request as draft July 30, 2021 14:01
Copy link
Contributor Author

This is the first iteration. It has to be improved as soon as DSP-API resolved the "update metadata" response. At the moment it's not possible to edit the label twice without refreshing the whole page.
For the moment we can't wait for new release of DSP-API because this will be v14.0.0 which contains a lot of breaking changes.

@kilchenmann kilchenmann marked this pull request as ready for review July 30, 2021 14:04
@kilchenmann kilchenmann requested review from mdelez and Vijeinath and removed request for mdelez July 30, 2021 14:04
Copy link

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good :)

@kilchenmann kilchenmann merged commit e2c9867 into main Aug 2, 2021
@kilchenmann kilchenmann deleted the wip/dsp-1801-edit-label branch August 2, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
enhancement New feature or request
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants