Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resource): create link / collection resource (DSP-1835) #501

merged 14 commits into from Aug 12, 2021


Copy link

@kilchenmann kilchenmann commented Aug 12, 2021

resolves DSP-1835 and resolves the issues mentioned in DSP-1820

After creating a linkObj resource it opens the new resource in a new tab. In this PR I have integrated the same logic when creating a new resource instance.

There's an "ugly" error from Angular lifecycle hook where I wasn't able to resolve it resp. when resolving it in DSP-APP we got another lifecycle hook error from DSP-UI and nothing works anymore. I hope to resolve the issue when moving DSP-UI components to DSP-APP (DSP-1857):

ERROR Error: NG0100: ExpressionChangedAfterItHasBeenCheckedError: 
Expression has changed after it was checked. Previous value: 'false'. Current value: 'true'.. 
Find more at

@kilchenmann kilchenmann self-assigned this Aug 12, 2021
@kilchenmann kilchenmann added the enhancement New feature or request label Aug 12, 2021
@kilchenmann kilchenmann changed the title feat(resource): create link / collection resource feat(resource): create link / collection resource (DSP-1835) Aug 12, 2021
@kilchenmann kilchenmann merged commit 8060756 into main Aug 12, 2021
@kilchenmann kilchenmann deleted the wip/dsp-1835-link-resource branch August 12, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
enhancement New feature or request
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants