Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schema): add error codes for validation (DSP-1902) #101

Merged
merged 9 commits into from Sep 23, 2021

Conversation

@irinaschubert
Copy link
Collaborator

@irinaschubert irinaschubert commented Sep 22, 2021

resolves DSP-1902

@irinaschubert irinaschubert self-assigned this Sep 22, 2021
@irinaschubert irinaschubert marked this pull request as ready for review Sep 22, 2021
@irinaschubert irinaschubert changed the title feat(schema): add error messages when validation fails (DSP-1902) feat(schema): add error codes for validation (DSP-1902) Sep 22, 2021
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

note my two comments. If they make sense to you, please change it accordingly. Otherwise, looks good.

Loading

knora/dsp_tools.py Show resolved Hide resolved
Loading
knora/dsplib/utils/onto_validate.py Show resolved Hide resolved
Loading
@irinaschubert irinaschubert merged commit 0bc6149 into main Sep 23, 2021
2 checks passed
Loading
@irinaschubert irinaschubert deleted the wip/dsp-1902-fix-schema-namespace branch Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants