Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(id-to-iri): extend xmlupload to allow references to existing resources (DEV-60) #108

Merged
merged 60 commits into from Nov 22, 2021

Conversation

irinaschubert
Copy link
Collaborator

@irinaschubert irinaschubert commented Oct 26, 2021

resolves DEV-60

@irinaschubert irinaschubert self-assigned this Oct 26, 2021
@irinaschubert irinaschubert changed the title feat(id2iri): extend xmlupload to allow references to existing resources feat(id2iri): extend xmlupload to allow references to existing resources (DEV-60) Oct 26, 2021
@irinaschubert irinaschubert changed the title feat(id2iri): extend xmlupload to allow references to existing resources (DEV-60) feat(idToIri): extend xmlupload to allow references to existing resources (DEV-60) Oct 26, 2021
@irinaschubert irinaschubert changed the title feat(idToIri): extend xmlupload to allow references to existing resources (DEV-60) feat(id-to-iri): extend xmlupload to allow references to existing resources (DEV-60) Oct 26, 2021
@irinaschubert irinaschubert force-pushed the wip/dev-60-incremental-xmlupload branch from fc7a061 to 3de3635 Compare Nov 4, 2021
@irinaschubert irinaschubert marked this pull request as ready for review Nov 22, 2021
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

looks good, just some minor comments

docs/dsp-tools-usage.md Outdated Show resolved Hide resolved
docs/dsp-tools-usage.md Show resolved Hide resolved
docs/dsp-tools-xmlupload.md Outdated Show resolved Hide resolved
knora/dsp_tools.py Outdated Show resolved Hide resolved
knora/dsp_tools.py Show resolved Hide resolved
knora/dsplib/utils/id_to_iri.py Outdated Show resolved Hide resolved
knora/dsplib/utils/id_to_iri.py Outdated Show resolved Hide resolved
knora/dsplib/utils/xml_upload.py Outdated Show resolved Hide resolved
requirements.txt Show resolved Hide resolved
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

LGTM

knora/dsplib/utils/xml_upload.py Outdated Show resolved Hide resolved
Co-authored-by: Balduin Landolt <33053745+BalduinLandolt@users.noreply.github.com>
@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Nov 22, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@irinaschubert irinaschubert merged commit 40b01db into main Nov 22, 2021
5 checks passed
@irinaschubert irinaschubert deleted the wip/dev-60-incremental-xmlupload branch Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants