Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(excel-to-json): allow comments in class and property definitions #111

Merged
merged 13 commits into from Jan 4, 2022

Conversation

mrivoal
Copy link
Contributor

@mrivoal mrivoal commented Nov 1, 2021

This PR updates dsp-tools' code to support rdfs:comment in classes and properties definition in order to provide a better documentation for the data.
It also updates accordingly the Excel templates used to generate classes and properties.

@mrivoal mrivoal requested a review from irinaschubert Nov 1, 2021
@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Nov 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@BalduinLandolt BalduinLandolt changed the title Wip/extending excel to json feat(excel-to-json): allow comments in class and property definitions Jan 3, 2022
Copy link
Collaborator

@irinaschubert irinaschubert left a comment

LGTM

@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Jan 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@BalduinLandolt BalduinLandolt merged commit 807959f into main Jan 4, 2022
5 checks passed
@BalduinLandolt BalduinLandolt deleted the wip/extending-excel-to-json branch Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants