Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update dsp-tools to work with API version 16.0.0 #117

Merged
merged 7 commits into from Nov 18, 2021

Conversation

irinaschubert
Copy link
Collaborator

@irinaschubert irinaschubert commented Nov 18, 2021

resolves DEV-246

@irinaschubert irinaschubert self-assigned this Nov 18, 2021
@irinaschubert irinaschubert marked this pull request as ready for review Nov 18, 2021
@irinaschubert
Copy link
Collaborator Author

@irinaschubert irinaschubert commented Nov 18, 2021

Hi @BalduinLandolt , apparently in the newest API version there is a comment needed for every single node in a list (not just the root node as until now). So now, in dsp-tools, if there is a missing comment in a list node, an empty comment (with language "en" and value "") is created. I think this is more user friendly than force the user to invent a comment for every single node. What do you think?

Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Looks good. Typing issues can be for some other time.

knora/dsplib/models/listnode.py Outdated Show resolved Hide resolved
@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Nov 18, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@irinaschubert irinaschubert merged commit af70e9b into main Nov 18, 2021
5 checks passed
@irinaschubert irinaschubert deleted the wip/dev-246-adjust-to-changes-in-api branch Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants