Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): list root node needs a comments object (DEV-61) #122

Merged
merged 4 commits into from Nov 25, 2021

Conversation

jnussbaum
Copy link
Collaborator

@jnussbaum jnussbaum commented Nov 24, 2021

resolves DEV-61

@jnussbaum jnussbaum requested a review from irinaschubert Nov 24, 2021
@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Nov 25, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@irinaschubert irinaschubert left a comment

I also updated the documentation and added a test case in the test ontology. Otherwise it looks good, thanks for your effort!

@jnussbaum jnussbaum merged commit 7bdc589 into main Nov 25, 2021
5 checks passed
@jnussbaum jnussbaum deleted the wip/dev-61-list-root-node-needs-a-comments branch Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants