Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-ontology): within an ontology, references to the ontology itself are not possible (DEV-135) #130

Merged
merged 12 commits into from Dec 1, 2021

Conversation

BalduinLandolt
Copy link
Collaborator

@BalduinLandolt BalduinLandolt commented Nov 30, 2021

resolves DEV-135
resolves DEV-278

@BalduinLandolt BalduinLandolt changed the title fix(create-ontology): within an ontology, references to the ontology itself are not possible fix(create-ontology): within an ontology, references to the ontology itself are not possible (DEV-135) Nov 30, 2021
Copy link
Collaborator

@irinaschubert irinaschubert left a comment

LGTM, I just looked at the code, shall I also test it locally?

for prefix, onto in context.items():
self._context[prefix] = OntoInfo(onto.removesuffix('#'), onto.endswith('#'))

# we always want the base ontologies/prefixes included in the context
Copy link
Collaborator

@irinaschubert irinaschubert Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very fond of these "we" comments. Maybe it can be changed to somewhat more neutral?

Copy link
Collaborator Author

@BalduinLandolt BalduinLandolt Dec 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right

if not self._context.get(k):
self._context[k] = v

# we always want the DSP-API ontologies/prefixes included in the context
Copy link
Collaborator

@irinaschubert irinaschubert Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very fond of these "we" comments. Maybe it can be changed to somewhat more neutral?

@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Dec 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@BalduinLandolt BalduinLandolt merged commit 6a40fc6 into main Dec 1, 2021
5 checks passed
@BalduinLandolt BalduinLandolt deleted the wip/DEV-135-referencing-local-ontologies branch Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants