Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restrict the creation of classes without cardinalities (DEV-305) #136

Merged
merged 10 commits into from Jan 4, 2022

Conversation

irinaschubert
Copy link
Collaborator

@irinaschubert irinaschubert commented Dec 21, 2021

resolves DEV-305

Note: Because of circular dependencies in the creation of properties and resource classes with dsp-tools (properties have fields object/subject which point to resource classes and resource classes point to properties), I decided to not allow the creation of resource classes without direct cardinalities with dsp-tools. It is questionable anyway whether this case will ever exist, so I considered it not to be a limitation of the user.

@irinaschubert irinaschubert self-assigned this Dec 21, 2021
@irinaschubert irinaschubert changed the title fix: integrate cardinality adding into resource creation (DEV-305) fix: restrict the creation of classes without cardinalities (DEV-305) Dec 21, 2021
@irinaschubert irinaschubert marked this pull request as ready for review Dec 21, 2021
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

I'm not sure the error handling works as intended right now. Please verify this - and if so, it's good to merge. (I also commented on some stylistics, feel free to ignore those)

knora/dsplib/utils/onto_create_ontology.py Show resolved Hide resolved
knora/dsplib/utils/onto_create_ontology.py Show resolved Hide resolved
knora/dsplib/utils/onto_create_ontology.py Outdated Show resolved Hide resolved
knora/dsplib/utils/onto_create_ontology.py Outdated Show resolved Hide resolved
knora/dsplib/utils/onto_create_ontology.py Outdated Show resolved Hide resolved
knora/dsplib/utils/onto_create_ontology.py Outdated Show resolved Hide resolved
knora/dsplib/utils/onto_create_ontology.py Outdated Show resolved Hide resolved
knora/dsplib/utils/onto_create_ontology.py Outdated Show resolved Hide resolved
knora/dsplib/utils/onto_create_ontology.py Show resolved Hide resolved
@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Jan 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@irinaschubert irinaschubert merged commit 5604a5b into main Jan 4, 2022
5 checks passed
@irinaschubert irinaschubert deleted the wip/dev-305-change-order-of-entity-creation branch Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants