Repository navigation
chore: improve ontology schema and extend tests (DEV-313) - #140
Merged
Merged
Conversation
BalduinLandolt
approved these changes
Jan 6, 2022
BalduinLandolt
left a comment
BalduinLandolt
left a comment
Collaborator
There was a problem hiding this comment.
looks good!
one cosmetic suggestion, but nothing to complain
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves DEV-313
resolves DEV-257
I removed anything-onto.json from testdata and tests because it was no longer valid (probably already some time ago). So, I extended test-onto.json a bit and used it instead. In that occasion I also extended the test for the
dsp-tools getcommand. The actual task of DEV-313 was an extension to the ontology schema to validate the gui_element and gui_attributes properties and their values.Besides that, this PR also resolves DEV-257: added the
subjectattribute to the documentation.