Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve ontology schema and extend tests (DEV-313) #140

Merged
merged 8 commits into from Jan 10, 2022

Conversation

irinaschubert
Copy link
Collaborator

@irinaschubert irinaschubert commented Jan 5, 2022

resolves DEV-313
resolves DEV-257

I removed anything-onto.json from testdata and tests because it was no longer valid (probably already some time ago). So, I extended test-onto.json a bit and used it instead. In that occasion I also extended the test for the dsp-tools get command. The actual task of DEV-313 was an extension to the ontology schema to validate the gui_element and gui_attributes properties and their values.

Besides that, this PR also resolves DEV-257: added the subject attribute to the documentation.

@irinaschubert irinaschubert self-assigned this Jan 5, 2022
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

looks good!
one cosmetic suggestion, but nothing to complain

test/e2e/test_tools.py Outdated Show resolved Hide resolved
@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Jan 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

looks good

@irinaschubert irinaschubert merged commit 656ccff into main Jan 10, 2022
5 checks passed
@irinaschubert irinaschubert deleted the wip/dev-313-improve-ontology-schema branch Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants