Repository navigation
fix(ontology): add default values for missing comments (DEV-337) - #141
Merged
Merged
Conversation
added 7 commits
January 10, 2022 09:54
BalduinLandolt
approved these changes
Jan 10, 2022
BalduinLandolt
left a comment
BalduinLandolt
left a comment
Collaborator
There was a problem hiding this comment.
looks good over all. As always with dsp-tools, there could be more refactoring and cosmetics done... but it also doesn't need to happen in this PR
|
Kudos, SonarCloud Quality Gate passed!
|
Author
|
Thanks for the review, @BalduinLandolt . I considered all your suggestions but the declaration of variables with None. These are needed to avoid the "local variable '...' might be referenced before assignment" warnings. If you know another, less verbose way to avoid these, I'm open to your suggestion! |
BalduinLandolt
approved these changes
Jan 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves DEV-337
Default value for missing comments for resources and properties is: "[no comment provided]".
In this PR I also added a check if a group, user or list provided inside the ontology already exists and if so, it just skips over it (instead of throwing an error). Like this, it is possible to repeat the ontology creation several times and it only creates a group, user or list if it does not already exist on the server. With this comes the possibility to update the project information (only longname, descriptions and keywords) - again without throwing an error like before. This makes local testing a lot more convenient.