Skip to content

chore(xml-upload): print XML validation errors when xmlupload fails due to validation (DEV-387) - #149

Merged
jnussbaum merged 2 commits into
mainfrom
wip/DEV-387-print-error-when-xml-validation-fails
Jan 28, 2022
Merged

jnussbaum merged 2 commits into
mainfrom
wip/DEV-387-print-error-when-xml-validation-fails

Conversation

@jnussbaum

Copy link
Copy Markdown
Collaborator

resolves DEV-387

@jnussbaum jnussbaum self-assigned this Jan 27, 2022

@irinaschubert irinaschubert left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did you try it out?

@jnussbaum

Copy link
Copy Markdown
Collaborator Author

@irinaschubert: Now you were super fast, giving your review even before I asked for it :-)
Yes, I tried it out, and it works as intended.

@irinaschubert

Copy link
Copy Markdown

@irinaschubert: Now you were super fast, giving your review even before I asked for it :-) Yes, I tried it out, and it works as intended.

Ah, sorry! I got a message that I was added as reviewer.. So, I thought it was ready. Well, nevermind :) It looks good anyway.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jnussbaum jnussbaum changed the title chore(xml-upload): print XML validation errors when xmlupload fails due to validation chore(xml-upload): print XML validation errors when xmlupload fails due to validation (DEV-387) Jan 28, 2022
@jnussbaum
jnussbaum merged commit 03554c2 into main Jan 28, 2022
@jnussbaum
jnussbaum deleted the wip/DEV-387-print-error-when-xml-validation-fails branch January 28, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants