New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve docs (DEV-450) #152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just see my note on the CHANGELOG.md, but apart from that it seems good to merge
### [1.8.1](https://www.github.com/dasch-swiss/dsp-tools/compare/v1.8.0...v1.8.1) (2022-01-11) | ||
## [1.8.1](https://www.github.com/dasch-swiss/dsp-tools/compare/v1.8.0...v1.8.1) (2022-01-11) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the CHANGELOG.md is automatically created. So changing stuff here will lead to inconsistencies in the future, once more automatic stuff is added... I'd suggest not doing this, but it's up to you.
(In case you're wondering why sometimes the versions are h2 and sometimes they are h3: that's the difference between minor and patch releases.)
h1 { | ||
font-weight: bold; | ||
padding-top: 50px; | ||
} | ||
h2 { | ||
font-weight: bold; | ||
padding-top: 50px; | ||
} | ||
h3 { | ||
font-weight: bold; | ||
padding-top: 50px; | ||
} | ||
h4 { | ||
font-weight: bold; | ||
padding-top: 50px; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notice that this might only affect the docs at https://dasch-swiss.github.io/dsp-tools/ . If you want it to take effect on docs.dasch.swiss, you may have to change things on the docs repo too. (I'm not sure though.)
Kudos, SonarCloud Quality Gate passed!
|
resolves DEV-450