Skip to content

docs: improve docs (DEV-450) - #152

Merged
jnussbaum merged 7 commits into
mainfrom
wip/dev-450-improve-docs
Feb 17, 2022
Merged

jnussbaum merged 7 commits into
mainfrom
wip/dev-450-improve-docs

Conversation

@jnussbaum

Copy link
Copy Markdown
Collaborator

resolves DEV-450

@jnussbaum jnussbaum self-assigned this Feb 9, 2022
@jnussbaum
jnussbaum requested review from BalduinLandolt and removed request for BalduinLandolt February 15, 2022 13:40

@BalduinLandolt BalduinLandolt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just see my note on the CHANGELOG.md, but apart from that it seems good to merge

Comment thread CHANGELOG.md
* **xmlupload:** use custom IRIs created from salsah ARKs for XML upload (DEV-179) ([#147](https://www.github.com/dasch-swiss/dsp-tools/issues/147)) ([873324a](https://www.github.com/dasch-swiss/dsp-tools/commit/873324ad4cd4fefd48d8d2fc37f08774285849d5))

### [1.8.1](https://www.github.com/dasch-swiss/dsp-tools/compare/v1.8.0...v1.8.1) (2022-01-11)
## [1.8.1](https://www.github.com/dasch-swiss/dsp-tools/compare/v1.8.0...v1.8.1) (2022-01-11)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the CHANGELOG.md is automatically created. So changing stuff here will lead to inconsistencies in the future, once more automatic stuff is added... I'd suggest not doing this, but it's up to you.
(In case you're wondering why sometimes the versions are h2 and sometimes they are h3: that's the difference between minor and patch releases.)

Comment on lines +5 to +20
h1 {
font-weight: bold;
padding-top: 50px;
}
h2 {
font-weight: bold;
padding-top: 50px;
}
h3 {
font-weight: bold;
padding-top: 50px;
}
h4 {
font-weight: bold;
padding-top: 50px;
}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice that this might only affect the docs at https://dasch-swiss.github.io/dsp-tools/ . If you want it to take effect on docs.dasch.swiss, you may have to change things on the docs repo too. (I'm not sure though.)

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jnussbaum
jnussbaum merged commit be5b69f into main Feb 17, 2022
@jnussbaum
jnussbaum deleted the wip/dev-450-improve-docs branch February 17, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants