Repository navigation
feat: make comments optional for new properties and resources (DEV-502) - #158
Merged
Merged
Conversation
jnussbaum
changed the title
irinaschubert
approved these changes
Feb 21, 2022
irinaschubert
left a comment
irinaschubert
left a comment
There was a problem hiding this comment.
LGTM just one minor typo issue. I assume you've tested it with an example ontology both for resources and properties?
| "name": "b", | ||
| "labels": { | ||
| "en": "b_label with no comment" | ||
| "en": "b_label with a comment" |
There was a problem hiding this comment.
"no" was correct, wasn't it? This node doesn't have a comment.
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves DEV-502