Skip to content

docs: add explanation how an Excel file for list creation must be structured (DEV-533) - #159

Merged
jnussbaum merged 4 commits into
mainfrom
wip/dev-533-add-excel_to_json_list-to-docs
Feb 22, 2022
Merged

jnussbaum merged 4 commits into
mainfrom
wip/dev-533-add-excel_to_json_list-to-docs

Conversation

@jnussbaum

Copy link
Copy Markdown
Collaborator

resolves DEV-533

@irinaschubert irinaschubert left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some suggestions for improvements, but feel free to chose whatever you find the best option.

Comment thread docs/dsp-tools-excel.md Outdated
Comment thread docs/dsp-tools-excel.md
},
"nodes": [
{
"name": "first-subnode",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "first-subnode",
"name": "first-node",

Comment thread docs/dsp-tools-excel.md
"name": "first-subnode",
"labels": {
"de": "erster Listenknoten",
"en": "first subnode"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"en": "first subnode"
"en": "first node of the list"

Comment thread docs/dsp-tools-excel.md
},
{
"name": "coarse-sand",
"name": "first-sublist",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my view, it is confusing to use the term "sub-list". The node called "first-sublist" here is the actual list. I would suggest using "list" or "my-list" or something similar.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand, the contents of Excel column A are already nodes/sublists. The top-level list name is defined by the file name.
In every case, my test data behaves that way...

Co-authored-by: irinaschubert <irina.schubert@dasch.swiss>
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jnussbaum
jnussbaum merged commit 660d57b into main Feb 22, 2022
@jnussbaum
jnussbaum deleted the wip/dev-533-add-excel_to_json_list-to-docs branch February 22, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants