Repository navigation
feat: add support for external ontologies (dev-512) - #170
Merged
irinaschubert merged 16 commits intoApr 11, 2022
Merged
Conversation
added 9 commits
March 28, 2022 10:05
irinaschubert
marked this pull request as ready for review
April 6, 2022 16:04
BalduinLandolt
approved these changes
Apr 7, 2022
BalduinLandolt
left a comment
BalduinLandolt
left a comment
Collaborator
There was a problem hiding this comment.
looks good, just some minor comments
jnussbaum
reviewed
Apr 7, 2022
jnussbaum
reviewed
Apr 7, 2022
Collaborator
|
LGTM, just some comments. I also added the additional Jira Issue that you fixed in the comment field of the PR. |
jnussbaum
self-requested a review
April 7, 2022 19:26
jnussbaum
approved these changes
Apr 7, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
irinaschubert
deleted the
wip/dev-512-add-support-for-external-ontologies
branch
April 11, 2022 10:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves DEV-512
resolves DEV-786