Repository navigation
chore: change to pipenv (DEV-764) - #177
Merged
Merged
Conversation
jnussbaum
changed the title
jnussbaum
commented
Apr 1, 2022
jnussbaum
commented
Apr 1, 2022
jnussbaum
commented
Apr 1, 2022
Collaborator
Author
|
@BalduinLandolt @irinaschubert : In makefile, line 22, two arguments are passed to setup.py: sdist and bdist_wheel, but these are not used. Should we remove them? |
BalduinLandolt
approved these changes
Apr 4, 2022
BalduinLandolt
left a comment
BalduinLandolt
left a comment
Collaborator
There was a problem hiding this comment.
See my comments for details, but overall it looks good
irinaschubert
approved these changes
Apr 4, 2022
| - `pipenv install --ignore-pipfile` is used to get a deterministic build in production | ||
|
|
||
| To install from source run: | ||
| This works because there are two files defining the dependencies: |
There was a problem hiding this comment.
Suggested change
| This works because there are two files defining the dependencies: | |
| There are two files defining the dependencies: |
Co-authored-by: irinaschubert <irina.schubert@dasch.swiss>
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves DEV-764