Skip to content

feat(xmlupload): support Baseclass MovingImageRepresentation - #185

Merged
jnussbaum merged 2 commits into
mainfrom
wip/dev-835-add-MovingImageRepresentation
Apr 26, 2022
Merged

jnussbaum merged 2 commits into
mainfrom
wip/dev-835-add-MovingImageRepresentation

Conversation

@jnussbaum

Copy link
Copy Markdown
Collaborator

resolves DEV-835

@jnussbaum jnussbaum self-assigned this Apr 26, 2022
@jnussbaum
jnussbaum requested a review from irinaschubert April 26, 2022 12:23

@irinaschubert irinaschubert left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there is no test, but I assume you've tested it manually?

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jnussbaum

Copy link
Copy Markdown
Collaborator Author

@irinaschubert: Yes, it's tested manually, and now there is also test data.

@jnussbaum
jnussbaum requested a review from irinaschubert April 26, 2022 13:04
@jnussbaum
jnussbaum merged commit 7ebf588 into main Apr 26, 2022
@jnussbaum
jnussbaum deleted the wip/dev-835-add-MovingImageRepresentation branch April 26, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants