Skip to content

chore: update schema-files (DEV-449) - #187

Merged
gNahcab merged 5 commits into
mainfrom
wip/dev-449-update-json-schema
Apr 28, 2022
Merged

chore: update schema-files (DEV-449)#187
gNahcab merged 5 commits into
mainfrom
wip/dev-449-update-json-schema

Conversation

@gNahcab

@gNahcab gNahcab commented Apr 26, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

resolves DEV-449

@gNahcab
gNahcab requested a review from jnussbaum April 26, 2022 15:31
@gNahcab gNahcab changed the title Wip/dev 449 update json schema Wip/chore Apr 26, 2022
@gNahcab
gNahcab marked this pull request as draft April 26, 2022 15:34
@gNahcab gNahcab changed the title Wip/chore chore: update schema-files (DEV-449) Apr 26, 2022
@gNahcab
gNahcab marked this pull request as ready for review April 26, 2022 15:50
@gNahcab
gNahcab requested review from jnussbaum and removed request for jnussbaum April 27, 2022 08:51
@gNahcab gNahcab self-assigned this Apr 27, 2022
@sonarqubecloud

sonarqubecloud Bot commented Apr 27, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

jnussbaum
jnussbaum reviewed Apr 28, 2022
View reviewed changes
Comment thread knora/dsplib/schemas/ontology.json
"required": [
"shortcode",
"shortname",
"longname",

@jnussbaum jnussbaum Apr 28, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should longname be optional? I think it's important to have it...

@irinaschubert irinaschubert Apr 28, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnussbaum that came from me. I saw this already some time ago and asked @gNahcab to adjust it. From the API side it's not mandatory: https://docs.dasch.swiss/DSP-API/03-apis/api-admin/projects/#create-a-new-project
I think it is good if DSP-TOOLS has the same restrictions as the API. Otherwise we need to maintain two different systems / logics which is much harder to keep up to date.

@jnussbaum jnussbaum Apr 28, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explaining, Irina. I approved the PR, and you can merge, @gNahcab 👍

jnussbaum
jnussbaum approved these changes Apr 28, 2022
View reviewed changes

@jnussbaum jnussbaum left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

irinaschubert
irinaschubert approved these changes Apr 28, 2022
View reviewed changes

@irinaschubert irinaschubert left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gNahcab
gNahcab merged commit 9a5a50b into main Apr 28, 2022
@gNahcab
gNahcab deleted the wip/dev-449-update-json-schema branch April 28, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnussbaum jnussbaum jnussbaum approved these changes
+1 more reviewer
@irinaschubert irinaschubert irinaschubert approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@gNahcab gNahcab

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gNahcab @irinaschubert @jnussbaum