Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(xmlupload): refactor xmlupload, add unittests (DEV-1043) #203

Merged
merged 6 commits into from Jun 23, 2022
Merged

chore(xmlupload): refactor xmlupload, add unittests (DEV-1043) #203

merged 6 commits into from Jun 23, 2022

Conversation

jnussbaum
Copy link
Collaborator

resolves DEV-1043

@jnussbaum jnussbaum self-assigned this Jun 23, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jnussbaum jnussbaum marked this pull request as ready for review June 23, 2022 14:52
BalduinLandolt
BalduinLandolt reviewed Jun 23, 2022
View reviewed changes
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you feel about moving all the newly created and xml-related files in the models folder to a subfolder xml?

@jnussbaum
Copy link
Collaborator Author

I thought about bringing some order into all these models, but I'm unsure about it. Intuitively, I don't like the idea of a xml subfolder. (The main reason why I am reluctant about reordering them, is because I don't know which classes belong together). So it seemed best to me to leave them all on top level.

irinaschubert
irinaschubert approved these changes Jun 23, 2022
View reviewed changes
Copy link

@irinaschubert irinaschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

knora/dsplib/models/projectContext.py
_shortcode: Optional[str]
_project_name: Optional[str]

def __init__(self, con: Connection, shortcode: Optional[str] = None):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docstring is missing, see the other classes

@BalduinLandolt
Copy link
Collaborator

I thought about bringing some order into all these models, but I'm unsure about it. Intuitively, I don't like the idea of a xml subfolder. (The main reason why I am reluctant about reordering them, is because I don't know which classes belong together). So it seemed best to me to leave them all on top level.

fair enough

@BalduinLandolt BalduinLandolt self-requested a review June 23, 2022 15:28
@jnussbaum jnussbaum merged commit fcf8384 into main Jun 23, 2022
6 checks passed
@jnussbaum jnussbaum deleted the wip/dev-1043-add-unittests branch June 23, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irinaschubert irinaschubert irinaschubert approved these changes

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

Assignees

@jnussbaum jnussbaum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jnussbaum @BalduinLandolt @irinaschubert