Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup api logging (DSP-1076) #46

Merged
merged 19 commits into from Feb 10, 2021
Merged

Conversation

@lrosenth
Copy link
Contributor

@lrosenth lrosenth commented Feb 8, 2021

Some cleanup of lgging of API errors
Some small fixes for the rosetta project

Afterwards acceptance a new version for Pypi will be created...

@lrosenth lrosenth requested review from subotic and danielasubotic Feb 8, 2021
Copy link
Collaborator

@subotic subotic left a comment

There are two CI errors that need to be fixed first. You can run the same tests locally with running make test.

Loading

@subotic subotic changed the title Wip/dsp 1076 cleanup api logging fix: cleanup api logging (DSP-1076) Feb 9, 2021
@lrosenth lrosenth requested a review from BalduinLandolt Feb 10, 2021
@lrosenth
Copy link
Contributor Author

@lrosenth lrosenth commented Feb 10, 2021

OK, test run through. rosetta is supported.... Let's fetz -- eh -- merge

Loading

@subotic subotic merged commit d48e704 into main Feb 10, 2021
2 checks passed
Loading
@subotic subotic deleted the wip/DSP-1076-cleanup-api-logging branch Feb 10, 2021
@subotic
Copy link
Collaborator

@subotic subotic commented Feb 10, 2021

@lrosenth thanks, I've merged it.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants