Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(dsp-tools-xmlupload): add Warning section (DSP-1693) #69

Merged

Conversation

@jnussbaum
Copy link
Contributor

@jnussbaum jnussbaum commented Jul 14, 2021

It is very important to know about this detail. Already two people ran into this, and it costed a lot of time to both of us. This warning is definitively needed.

It is very important to know about this detail. Already two people ran into this, and it costed a lot of time to both of us. This warning is definitively needed.

| ⚠ Look out |
|:----------|
| In case of a cardinality 1-n, you must **NOT** create multiple `<text-prop>` tags, but multiple `<text>` tags in one single `<text-prop>`! |
Copy link
Collaborator

@irinaschubert irinaschubert Jul 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| In case of a cardinality 1-n, you must **NOT** create multiple `<text-prop>` tags, but multiple `<text>` tags in one single `<text-prop>`! |
| In case of a cardinality 1-n, don't use multiple `<text-prop>` tags, but multiple `<text>` tags inside `<text-prop>`.|

Loading

Copy link
Collaborator

@irinaschubert irinaschubert Jul 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put it more neutrally.

Loading

@jnussbaum jnussbaum merged commit 05baf3d into main Jul 14, 2021
3 checks passed
Loading
@jnussbaum jnussbaum deleted the docs(dsp-tools-xmlupload)-add-Warning-section-(DSP-1693) branch Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants