DSP-652 FIX: Boolean add button

projects/dsp-ui/src/lib/viewer/views/property-view/property-view.component.html

@@ -36,10 +36,7 @@
                     </div>
                     <!-- Add button -->
                     <!-- temporary hack to hide add button for an XML value -->
-                    <div *ngIf="prop.guiDef.propertyIndex !== 'http://0.0.0.0:3333/ontology/0001/anything/v2#hasRichtext' &&
-                        addButtonIsVisible &&
-                        prop.guiDef.cardinality !== 1 &&
-                        propID !== prop.propDef.id">
+                    <div *ngIf="addValueIsAllowed(prop) && prop.guiDef.propertyIndex !== 'http://0.0.0.0:3333/ontology/0001/anything/v2#hasRichtext'">
                         <button class="create" (click)="showAddValueForm(prop)" title="Add a new value">
                             <mat-icon>add_box</mat-icon>
                         </button>

projects/dsp-ui/src/lib/viewer/views/property-view/property-view.component.spec.ts

@@ -217,12 +217,34 @@ describe('PropertyViewComponent', () => {
             testHostFixture.detectChanges();
         });
 
-        it('should show an add button under each property that has a value component and for which the cardinality is not 1', () => {
+        it('should show an add button under each property that has a value component and value and appropriate cardinality', () => {
             const addButtons = propertyViewComponentDe.queryAll(By.css('button.create'));
             expect(addButtons.length).toEqual(13);
 
         });
 
+        it('should show an add button under a property with a cardinality of 1 and does not have a value', () => {
+
+            // show all properties so that we can access properties with no values
+            testHostComponent.showAllProps = true;
+            testHostFixture.detectChanges();
+
+            let addButtons = propertyViewComponentDe.queryAll(By.css('button.create'));
+
+            // current amount of buttons should equal 18 because the boolean property shouldn't have an add button if it has a value
+            expect(addButtons.length).toEqual(18);
+
+            // remove value from the boolean property
+            testHostComponent.propArray[9].values = [];
+
+            testHostFixture.detectChanges();
+
+            // now the boolean property should have an add button so the amount of add buttons on the page should increase by 1
+            addButtons = propertyViewComponentDe.queryAll(By.css('button.create'));
+            expect(addButtons.length).toEqual(19);
+
+        });
+
         it('should show an add value component when the add button is clicked', () => {
             const addButtonDebugElement = propertyViewComponentDe.query(By.css('button.create'));
             const addButtonNativeElement = addButtonDebugElement.nativeElement;

projects/dsp-ui/src/lib/viewer/views/property-view/property-view.component.ts

@@ -53,7 +53,6 @@ export class PropertyViewComponent implements OnInit, OnDestroy {
     addButtonIsVisible: boolean; // used to toggle add value button
     addValueFormIsVisible: boolean; // used to toggle add value form field
     propID: string; // used in template to show only the add value form of the corresponding value
-    readOnlyProp: boolean; // used in template to not show an "add" button for properties we do not yet have a way to create/edit
 
     valueOperationEventSubscription: Subscription;
 
@@ -86,10 +85,8 @@ export class PropertyViewComponent implements OnInit, OnDestroy {
      * Called from the template when the user clicks on the add button
      */
     showAddValueForm(prop: PropertyInfoValues) {
-
         this.propID = prop.propDef.id;
         this.addValueFormIsVisible = true;
-
     }
 
     /**
@@ -100,4 +97,24 @@ export class PropertyViewComponent implements OnInit, OnDestroy {
         this.addButtonIsVisible = true;
         this.propID = undefined;
     }
+
+    /**
+     * Given a resource property, check if an add button should be displayed under the property values
+     *
+     * @param prop the resource property
+     */
+    addValueIsAllowed(prop: PropertyInfoValues): boolean {
+        // check if cardinality allows for a value to be added
+        if (prop.guiDef.cardinality !== 1 ||
+            prop.guiDef.cardinality === 1 && prop.values.length === 0) {
+
+            // check that the value component does not already have an add value form open
+            // and that the user has write permissions
+            if (this.propID !== prop.propDef.id && this.addButtonIsVisible) {
+                return true;
+            }
+        }
+
+        return false;
+    }
 }