Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 1.0.1 #255

Merged
merged 2 commits into from Jan 15, 2021
Merged

chore: release 1.0.1 #255

merged 2 commits into from Jan 15, 2021

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented Jan 8, 2021

馃 I have created a release *beep* *boop*

1.0.1 (2021-01-15)

Bug Fixes

Maintenance


This PR was generated with Release Please. See documentation.

mpro7
mpro7 approved these changes Jan 11, 2021
@mpro7
Copy link
Contributor

mpro7 commented Jan 11, 2021

@kilchenmann I'm not sure if this hasn't been overwritten by merge of #251. Shouldn't be at least the #250 also in the changelog?

@kilchenmann
Copy link
Contributor Author

@kilchenmann I'm not sure if this hasn't been overwritten by merge of #251. Shouldn't be at least the #250 also in the changelog?

Yes you're right. It's overwritten by merge #251. But then it seems that Release Please works again. I had the following in my CHANGELOG:

1.0.1 (2021-01-09)

Bug Fixes

Maintenance

Maybe we can update this PR just before releasing. What do you think @mpro7?

@kilchenmann
Copy link
Contributor Author

kilchenmann commented Jan 12, 2021

I just pushed my changes accidentally but now I saw that we have two CHANGELOG files. Release please is configured for the lib which means it adds the CHANGELOG to the projeces/dsp-ui folder. Same for the package.json file. It updates the version number in /projects and not in root folder. I will clean up in a separate branch 鈫 done in #256

@daschbot daschbot force-pushed the release-v1.0.1 branch 3 times, most recently from d9388bc to c1939b7 Compare January 15, 2021 08:49
mdelez
mdelez approved these changes Jan 15, 2021
@mdelez mdelez merged commit e9b0f01 into main Jan 15, 2021
@mdelez mdelez deleted the release-v1.0.1 branch January 15, 2021 13:36
@kilchenmann kilchenmann restored the release-v1.0.1 branch January 15, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants