Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(viewer): set correct rgba value (DSP-1588) #288

Merged
merged 1 commit into from Apr 30, 2021

Conversation

kilchenmann
Copy link
Contributor

resolves DSP-1588

@kilchenmann kilchenmann requested a review from mdelez April 30, 2021 07:04
@kilchenmann kilchenmann self-assigned this Apr 30, 2021
@kilchenmann kilchenmann added the bug Something isn't working label Apr 30, 2021
@@ -16,7 +16,7 @@
}

.color-preview {
border: 1px solid rgba(33,33,33.5);
border: 1px solid rgba(33,33,33,.5);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.5 or 0.5??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, in scss we don't need a leading 0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mdelez
mdelez approved these changes Apr 30, 2021
Copy link
Contributor

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE!

@kilchenmann kilchenmann merged commit 01daed4 into main Apr 30, 2021
8 checks passed
@kilchenmann kilchenmann deleted the wip/dsp-1588-set-correct-rgba-value branch April 30, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants