New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(advanced search): update naming to advanced search (DSP-1651) #295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor grammar/spelling corrections
- selection of a resource class belonging to the selected ontology (optional) | ||
- specification of properties, comparison operators, and values (optional). | ||
|
||
Although selection of a resource or a property ore both are optional, either a resource class has to be selected or at least one property has to be specified, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ore -> or (unless we're mining now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 8d3c3f2
Depending on the value type of the chosen property, | ||
one or more of the following comparison operators can be selected: | ||
|
||
- `is equal to`: value equality: same number, exact same string, overlap of date periods, same target resource. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"matching date periods" is probably more clear here (same for the instances below), unless you truly do mean an overlap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thing is that each date is represented as a period in DSP-API. All kinds of overlap count as a match, e.g., a search for a date with day precision will match a value with year precision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair. It's fine the way it is then :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand why you asked though.
Maybe it could be covered in more detail in the DSP-API docs and could be linked to from here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, I am not sure how many technical details a user of the GUI should know
- `is equal to`: value equality: same number, exact same string, overlap of date periods, same target resource. | ||
- `is not equal to`: value inequality: not same number, not exact same string, no overlap of date periods, not same target resource. | ||
- `is greater than`: value comparison: number is greater than search value, date period begins after search value. | ||
- `is greater than or equal to` value equality / value comparison: number is equal or greater than search value, overlap of date periods or date period begins after search value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
equal to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 8d3c3f2
- `is greater than`: value comparison: number is greater than search value, date period begins after search value. | ||
- `is greater than or equal to` value equality / value comparison: number is equal or greater than search value, overlap of date periods or date period begins after search value. | ||
- `is less than`: value comparison: number is less than search value, date period ends before search value. | ||
- `is less than or equal to`: value equality / value comparison: number is equal or less than search value, overlap of date periods or date period ends before search value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
equal to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 8d3c3f2
- `is less than`: value comparison: number is less than search value, date period ends before search value. | ||
- `is less than or equal to`: value equality / value comparison: number is equal or less than search value, overlap of date periods or date period ends before search value. | ||
- `exists`: a value for the given property exists. | ||
- `is like`: search value is contained in a text using the SPARQL [REGEX](https://www.w3.org/TR/sparql11-query/#func-regex) function (support of regular expressions). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
support of -> supports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 8d3c3f2
|
||
### Regular Expressions (is like) | ||
|
||
The `is like` operator lets the user search for texts that are *like* the search value, supporting regular expressions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the search value, supporting regular expressions. -> the search value via the support of regular expressions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 8d3c3f2
|
||
The extended search allows you to filter by project, by source type (resource class), or by the metadata (properties) of source types. Each filter can be standalone or combined. The metadata field can be precisely filtered with criteria such as "contains", "like", "equals to", "exists" or in case of a date value with "before" or "after". In addition, for a metadata field that is connected to another source type, it's possible to filter by this second source type. If you are looking for the source type "Photograph" with the metadata field "Photographer", which is connected to source type "Person", you can search for photograph(s) taken by person(s) who is born before February 1970. The result of this request will be an intersection of the two source types. | ||
The advanced search allows you to filter by project, by source type (resource class), or by the metadata (properties) of source types. Each filter can be standalone or combined. The metadata field can be precisely filtered with criteria such as "contains", "like", "equals to", "exists" or in case of a date value with "before" or "after". In addition, for a metadata field that is connected to another source type, it's possible to filter by this second source type. If you are looking for the source type "Photograph" with the metadata field "Photographer", which is connected to source type "Person", you can search for photograph(s) taken by person(s) who is born before February 1970. The result of this request will be an intersection of the two source types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each filter can be standalone or combined. -> Each filter can be used individually or combined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 8d3c3f2
docs/how-to-use/search/index.md
Outdated
@@ -14,7 +14,7 @@ DspSearchModule is part of @dasch-swiss/dsp-ui, follow [the installation guide]( | |||
|
|||
## Components | |||
|
|||
This module contains various components to search. The main component is the dsp-search-panel, which contains the dsp-fulltext-search, dsp-extended-search and dsp-expert-search. All of them can be used standalone or in combination in dsp-search-panel. | |||
This module contains various components to search. The main component is the dsp-search-panel, which contains the dsp-fulltext-search, dsp-advanced-search and dsp-expert-search. All of them can be used standalone or in combination in dsp-search-panel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
standalone -> individually (standalone is correct and understandable, I would just personally use individually)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, some typo to fix though.
## Introduction | ||
|
||
The `AdvancedSearchComponent` allows for the creation of complex queries using a graphical widget. | ||
The widget's contents are then turned into a string representing a Gravsearch (SPAQRL) query to be sent to DSP-API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: SPARQL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 8d3c3f2
- selection of a resource class belonging to the selected ontology (optional) | ||
- specification of properties, comparison operators, and values (optional). | ||
|
||
Although selection of a resource or a property ore both are optional, either a resource class has to be selected or at least one property has to be specified, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: ore > or
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already caught be @mdelez :-)
- `is greater than or equal to` value equality / value comparison: number is equal or greater than search value, overlap of date periods or date period begins after search value. | ||
- `is less than`: value comparison: number is less than search value, date period ends before search value. | ||
- `is less than or equal to`: value equality / value comparison: number is equal or less than search value, overlap of date periods or date period ends before search value. | ||
- `exists`: a value for the given property exists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sometimes you start with a "A" value, sometimes not > make it consistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 8d3c3f2
mkdocs.yml
Outdated
@@ -18,7 +18,7 @@ nav: | |||
- Introduction Search: how-to-use/search/index.md | |||
- Search-panel: how-to-use/search/search-panel.md | |||
- Fulltext search: how-to-use/search/fulltext-search.md | |||
- Extended search: how-to-use/search/extended-search.md | |||
- advanced search: how-to-use/search/advanced-search.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be picky: Advanced
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 8d3c3f2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, thanks for requesting the review @tobiasschweizer :-)
resolves DSP-1651
This PR introduces a new user guideline for the advanced search: https://github.com/dasch-swiss/dsp-ui-lib/blob/fd0ef9cb9fa3ba867cbf4d9cc5a346a0f6e5ae83/docs/how-to-use/search/advanced-search-user-docs.md