New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Action Module Playground & Components Missing Imports #97
Conversation
The warnings when running the test are gone :-) I still get this when building the lib
You can simply add an entry to |
Ah, sorry I thought you said you wanted a separate PR for this in our call but I'm okay doing it in this one. Fixed in 3c42030 |
Yes, I said this, sorry. I should be more consistent :-) |
projects/dsp-ui/ng-package.json
Outdated
@@ -7,7 +7,8 @@ | |||
"@knora/api": "@knora/api", | |||
"ngx-color-picker": "ngxColorPicker", | |||
"jdnconvertiblecalendar": "jdnconvertiblecalendar", | |||
"jdnconvertiblecalendardateadapter": "jdnconvertiblecalendardateadapter" | |||
"jdnconvertiblecalendardateadapter": "jdnconvertiblecalendardateadapter", | |||
"ts-md5": "Md5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be "tsMd5" on the right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both seem to work but I changed it to "tsMd5" in 91d6b27
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe you can put what you want, I don't know. "tsMd5" is just what the compiler guessed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
And sorry for being confused myself about my on proposals.
https://dasch.myjetbrains.com/youtrack/issue/DSP-333