Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to ontology metadata #1703

Merged
merged 7 commits into from Sep 9, 2020

Conversation

SepidehAlassi
Copy link
Contributor

@SepidehAlassi SepidehAlassi commented Sep 8, 2020

resolves DSP-548

  • payload/request for create ontology can have an optional comment parameter. (messages)
  • Add a given comment to the ontology metadata (responder)
  • Return ontology metadata comment in response JSON (messages)
  • Add unit test for creation of ontology with a comment and check that the comment is returned correctly as part of the metadata
  • Add e2e tests
  • Add test data (route)
  • update documentation

closes #1690

@SepidehAlassi SepidehAlassi self-assigned this Sep 9, 2020
@SepidehAlassi SepidehAlassi added API/V2 enhancement improve existing code or new feature ontology labels Sep 9, 2020
@SepidehAlassi SepidehAlassi marked this pull request as ready for review September 9, 2020 12:29
Copy link

@benjamingeer benjamingeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but we need to be able to change the comment, too (in ChangeOntologyMetadataRequestV2), right?

@SepidehAlassi
Copy link
Contributor Author

SepidehAlassi commented Sep 9, 2020

This looks good, but we need to be able to change the comment, too (in ChangeOntologyMetadataRequestV2), right?

yes, I am aware of that. I thought to do it in another user story.

Copy link

@benjamingeer benjamingeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, in that case this is fine. Thank you!

@SepidehAlassi
Copy link
Contributor Author

OK, in that case this is fine. Thank you!

thanks for your quick review!

@SepidehAlassi SepidehAlassi merged commit ab6fe36 into develop Sep 9, 2020
@SepidehAlassi SepidehAlassi deleted the wip/DSP-548-OntologyComments branch September 9, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API/V2 enhancement improve existing code or new feature ontology
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating ontology ignores rdfs:comment field (small snafu....)
2 participants