Skip to content

/cpu-audio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyfill 24 hours input type="time" into Chapter Ed #63

Closed
dascritch opened this issue Apr 29, 2019 · 3 comments

Comments

Assignees
No one assigned
Labels
bug buggy browser enhancement good first issue
Projects
None yet
Milestone
No milestone
1 participant
@dascritch
@dascritch
Copy link
Owner

commented Apr 29, 2019

This page is using <input type="time"> to insert a time position/length.... but the American locale switches it in 12 hours format.

I've tried to use lang="fr" attribute, it doesn't work, all browsers rely on OS/Software locale for this 12/24 hours switch.

I should polyfill it with a 24 hours version... written from scratch... I'm not happy about that.

@dascritch dascritch added bug buggy browser enhancement good first issue labels Apr 29, 2019

@dascritch

This comment has been minimized.

Sign in to view
Copy link
Owner Author

commented May 7, 2019

Maybe inputmode="numeric" pattern="^([0-5]?[0-9]:){0,2}[0-5]?[0-9]$" , but not really nice
@dascritch

This comment has been minimized.

Sign in to view
Copy link
Owner Author

commented May 9, 2019

Removing input type="time from player. May be later

dascritch added a commit that referenced this issue May 9, 2019

@dascritch
Removing <input type="time"> in hanheld navigation 
as it can use a 12 hours format and so is improper for durations
Polyfill 24 hours input type="time" into Chapter Ed #63
efbf568

dascritch added a commit that referenced this issue May 13, 2019

@dascritch
Polyfill 24 hours input type="time" into Chapter Ed #63
1f06095

@dascritch dascritch closed this May 13, 2019

dascritch added a commit that referenced this issue May 13, 2019

@dascritch
Document release info 
Polyfill 24 hours input type="time" into Chapter Ed #63
69c3c24
@dascritch

This comment has been minimized.

Sign in to view
Copy link
Owner Author

commented Jun 12, 2019

Explained in French : https://dascritch.net/post/2019/06/05/Retravailler-un-lecteur-web-audio-dans-les-petites-largeurs#mauvaise_surprise_time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.