Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyfill 24 hours input type="time" into Chapter Ed #63

Closed
dascritch opened this issue Apr 29, 2019 · 3 comments
Closed

Polyfill 24 hours input type="time" into Chapter Ed #63

dascritch opened this issue Apr 29, 2019 · 3 comments

Comments

@dascritch
Copy link
Owner

@dascritch dascritch commented Apr 29, 2019

This page is using <input type="time"> to insert a time position/length.... but the American locale switches it in 12 hours format.

I've tried to use lang="fr" attribute, it doesn't work, all browsers rely on OS/Software locale for this 12/24 hours switch.

I should polyfill it with a 24 hours version... written from scratch... I'm not happy about that.

@dascritch
Copy link
Owner Author

@dascritch dascritch commented May 7, 2019

Maybe inputmode="numeric" pattern="^([0-5]?[0-9]:){0,2}[0-5]?[0-9]$" , but not really nice

@dascritch
Copy link
Owner Author

@dascritch dascritch commented May 9, 2019

Removing input type="time from player. May be later

dascritch added a commit that referenced this issue May 9, 2019
as it can use a 12 hours format and so is improper for durations
Polyfill 24 hours input type="time" into Chapter Ed #63
@dascritch dascritch closed this May 13, 2019
dascritch added a commit that referenced this issue May 13, 2019
Polyfill 24 hours input type="time" into Chapter Ed #63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant