Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server write #57

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Server write #57

wants to merge 6 commits into from

Conversation

davidbuttar
Copy link
Contributor

@davidbuttar davidbuttar commented Oct 4, 2018

No description provided.

@davidbuttar davidbuttar requested a review from shahmirj Oct 4, 2018
@shahmirj
Copy link
Member

@shahmirj shahmirj commented Oct 5, 2018

Umh looks like you need to rebase from master

@@ -35,7 +35,7 @@
#define DASHEE_SERVOD_THREADS_TICK_CONTROLLER 50000
#define DASHEE_SERVOD_THREADS_TICK_SERVER 25000
#define DASHEE_SERVOD_THREADS_TICK_SENSOR 25000
#define DASHEE_SERVOD_FALLBACK_TIMEOUT 250
#define DASHEE_SERVOD_FALLBACK_TIMEOUT 300
Copy link
Member

@shahmirj shahmirj Oct 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure about this, I think we should test it

@@ -14,36 +14,35 @@ using namespace dashee;
*
Copy link
Member

@shahmirj shahmirj Oct 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there actually any logical change in this file

@shahmirj shahmirj added this to To do in Dashee-client via automation Oct 5, 2018
@davidbuttar
Copy link
Contributor Author

@davidbuttar davidbuttar commented Oct 5, 2018

Umh looks like you need to rebase from master

The files changed seems correct, so who cares

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Dashee-client
  
To do
Development

Successfully merging this pull request may close these issues.

None yet

2 participants