New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server write #57

Open
wants to merge 6 commits into
base: master
from

Conversation

2 participants
@davidbuttar
Contributor

davidbuttar commented Oct 4, 2018

No description provided.

@davidbuttar davidbuttar requested a review from shahmirj Oct 4, 2018

@shahmirj

This comment has been minimized.

Show comment
Hide comment
@shahmirj

shahmirj Oct 5, 2018

Member

Umh looks like you need to rebase from master

Member

shahmirj commented Oct 5, 2018

Umh looks like you need to rebase from master

@@ -35,7 +35,7 @@
#define DASHEE_SERVOD_THREADS_TICK_CONTROLLER 50000
#define DASHEE_SERVOD_THREADS_TICK_SERVER 25000
#define DASHEE_SERVOD_THREADS_TICK_SENSOR 25000
#define DASHEE_SERVOD_FALLBACK_TIMEOUT 250
#define DASHEE_SERVOD_FALLBACK_TIMEOUT 300

This comment has been minimized.

@shahmirj

shahmirj Oct 5, 2018

Member

Are we sure about this, I think we should test it

@shahmirj

shahmirj Oct 5, 2018

Member

Are we sure about this, I think we should test it

@@ -14,36 +14,35 @@ using namespace dashee;
*

This comment has been minimized.

@shahmirj

shahmirj Oct 5, 2018

Member

Is there actually any logical change in this file

@shahmirj

shahmirj Oct 5, 2018

Member

Is there actually any logical change in this file

@shahmirj shahmirj added this to To do in Dashee-client via automation Oct 5, 2018

@davidbuttar

This comment has been minimized.

Show comment
Hide comment
@davidbuttar

davidbuttar Oct 5, 2018

Contributor

Umh looks like you need to rebase from master

The files changed seems correct, so who cares

Contributor

davidbuttar commented Oct 5, 2018

Umh looks like you need to rebase from master

The files changed seems correct, so who cares

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment