Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish the cli to NPM registry #47

Closed
Elias-Serneels opened this issue Jan 17, 2023 · 2 comments
Closed

Publish the cli to NPM registry #47

Elias-Serneels opened this issue Jan 17, 2023 · 2 comments
Assignees
Labels
features New feature or request

Comments

@Elias-Serneels
Copy link

It would be great if we could install (and update!) the cli using NPM.

This:
npx @dashlane/cli
Or:
npm i -g @dashlane/cli

instead of this:

brew install typescript
git clone git@github.com:Dashlane/dashlane-cli.git
cd dashlane-cli
npm run build
npm link
npm install
@Mikescops
Copy link
Member

Hello,

Thanks for the suggestion, actually we already thought about it but there is a security constraints that prevents us to do so.
In fact, when using the keychain (on any of the OSes) the owner of the secrets is the process that created them, and when you use the npm package with node directly, node is the owner which means that any other node process can grab the secret from the keychain.

I believe that's a security issue, which we mitigate when the application is packaged in its own binary.

I'll leave the thread open because I agree that would be a nice to have.

@Mikescops Mikescops added the features New feature or request label Jan 18, 2023
@Mikescops
Copy link
Member

So after reviewing this option again with the security team at Dashlane, we think that running the CLI with the nodejs process causes a risk when used with the keychain. As it is the default and most common behaviour, we won't publish on npmjs the resulting package.

On the other hand, we are going to provide a homebrew package (with compatibility on both macos and linux x64/arm64).

Hope this covers your use cases.

@Mikescops Mikescops self-assigned this Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
features New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants