-
Notifications
You must be signed in to change notification settings - Fork 105
Subclass Error to handle Server and Client errors #109
Conversation
|
I wasn't able to figure out how to simulate 4xx and 5xx errors for testing (without using VCR). |
Faraday's ClientError is raised for status codes 400...600 so we'll never need to send the rescued exception straight to Error
|
This PR subclasses |
|
Finally figured out how to mock the Faraday error we're rescuing without using VCR. The tests add assertions for all status codes for the range |
|
*bump* |
|
Looks good. Sorry for the delay. |
|
No problem. Thanks! |
Closes #61