From 4ae52758bd1bdc786d2926595044da8c4a059d2f Mon Sep 17 00:00:00 2001 From: Alexander Block Date: Mon, 11 Mar 2019 09:46:40 +0100 Subject: [PATCH] Remove size check in CDKGSessionManager::GetVerifiedContributions It's actually not true that these should always be the same. In case a quorum is built and the total number of masternodes in the network is below the quorum size, we might still end up having a valid quorum as long as the total number of masternodes is >= minSize. --- src/llmq/quorums_dkgsessionmgr.cpp | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/llmq/quorums_dkgsessionmgr.cpp b/src/llmq/quorums_dkgsessionmgr.cpp index a8221f1dbf4fd..edb4556744ecb 100644 --- a/src/llmq/quorums_dkgsessionmgr.cpp +++ b/src/llmq/quorums_dkgsessionmgr.cpp @@ -216,11 +216,6 @@ bool CDKGSessionManager::GetVerifiedContributions(Consensus::LLMQType llmqType, { auto members = CLLMQUtils::GetAllQuorumMembers(llmqType, quorumHash); - if (validMembers.size() != members.size()) { - // should never happen as we should always call this method with correct params - return false; - } - memberIndexesRet.clear(); vvecsRet.clear(); skContributionsRet.clear();