Permalink
Browse files

[qa] Avoid race in preciousblock test.

If node 0 is sufficiently fast to announce its block to node 1,
node 1 might already have the block by the time the
node_sync_via_rpc loop gets around to node 1, resulting in the
submitblock result "duplicate-inconclusive" as node 1 has the block,
but prefers an alternate chain.
  • Loading branch information...
TheBlueMatt committed Dec 19, 2016
1 parent 9a0b2f4 commit 8baaba653ef67097eb3d3a4b4d25f907111830b1
Showing with 1 addition and 1 deletion.
  1. +1 −1 qa/rpc-tests/preciousblock.py
@@ -102,7 +102,7 @@ def run_test(self):
assert_equal(self.nodes[2].getblockcount(), 6)
hashL = self.nodes[2].getbestblockhash()
print("Connect nodes and check no reorg occurs")
node_sync_via_rpc(self.nodes[0:3])
node_sync_via_rpc(self.nodes[1:3])
connect_nodes_bi(self.nodes,1,2)
connect_nodes_bi(self.nodes,0,2)
assert_equal(self.nodes[0].getbestblockhash(), hashH)

0 comments on commit 8baaba6

Please sign in to comment.