docs: Properly alphabetize output of CLI --help option (backport 12331) #3681

Minh20 · 2020-08-30T03:50:57Z

Alphebetize CLI --help output #3614

Properly alphabetize output of CLI

PastaPastaPasta · 2020-08-30T04:46:18Z

haven't taken a look yet, however, in the future, try to avoid closing a PR just to open a new one, because now the discussion we had on the old PR we can't view here. Also it kindof just clutters up the repo. Granted, I did this exact same thing when I was getting started because git was confusing and I didn't understand it, so if you need help with something like git stuff, let us know and we can likely help you

Minh20 · 2020-08-30T05:09:29Z

haven't taken a look yet, however, in the future, try to avoid closing a PR just to open a new one, because now the discussion we had on the old PR we can't view here. Also it kindof just clutters up the repo. Granted, I did this exact same thing when I was getting started because git was confusing and I didn't understand it, so if you need help with something like git stuff, let us know and we can likely help you

Thanks for the feedback and offering help for the git stuff. I'll pay attention for future pull requests.

src/init.cpp

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

PastaPastaPasta · 2020-08-31T18:24:46Z

feature_shutdown.py failure here: https://gitlab.com/dashpay/dash/-/jobs/711537367 is weird... No need for you to worry about this @Minh20

src/init.cpp

src/dash-cli.cpp

src/init.cpp

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

UdjinM6 · 2020-09-03T13:43:25Z

Pls see UdjinM6@769f08f and maybe UdjinM6@bc2ac58 (or just sort options in src/wallet/init.cpp properly instead but imo wallet has so many options already that it kind of makes sense to split them in few more groups)

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

UdjinM6 · 2020-09-10T11:40:58Z

Still waiting for src/wallet/init.cpp updates...

PastaPastaPasta · 2020-09-16T18:31:06Z

Look https://github.com/dashpay/dash/pull/3681/files, you messed some stuff up

…ize"" This reverts commit 0edae12.

PastaPastaPasta · 2020-09-20T22:44:13Z

@Minh20 see commits UdjinM6@bc2ac58 and UdjinM6@769f08f

UdjinM6

ACK

PastaPastaPasta

utACK, looks good

…1) (dashpay#3681) * Helpmessage outp alphabetized Properly alphabetize output of CLI * Helpmessage outp alphabetized Properly alphabetize output of CLI * Update src/init.cpp Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com> * Update src/init.cpp Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com> * Update src/init.cpp Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com> * Update src/init.cpp Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com> * Update src/init.cpp Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com> * Update src/init.cpp Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com> * Update src/init.cpp Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com> * Update src/init.cpp Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com> * Update src/init.cpp Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com> * Update src/dash-cli.cpp Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com> * Update src/init.cpp Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com> * Update src/dash-cli.cpp Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com> * Update src/init.cpp Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com> * Update src/init.cpp Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com> * Update src/init.cpp Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com> * Update src/init.cpp Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com> * Update src/init.cpp Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com> * Auto stash before merge of "alphabetize" and "origin/alphabetize" * Revert "Auto stash before merge of "alphabetize" and "origin/alphabetize"" This reverts commit 0edae12. * Changes for 769f08f * changes for bc2ac58 Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

Minh20 added 3 commits August 30, 2020 09:30

Helpmessage outp alphabetized

fa6d2a1

Properly alphabetize output of CLI

Helpmessage outp alphabetized

decc468

Properly alphabetize output of CLI

docs: Properly alphabetize output of CLI --help option (backport 12331)

fb61654

Minh20 changed the base branch from master to develop August 30, 2020 03:51

UdjinM6 requested changes Aug 30, 2020

View reviewed changes

Minh20 and others added 8 commits August 31, 2020 07:58

Update src/init.cpp

1e8df08

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

Update src/init.cpp

07cf212

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

Update src/init.cpp

d67eee7

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

Update src/init.cpp

113bbe8

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

Update src/init.cpp

8b605e5

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

Update src/init.cpp

b53e633

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

Update src/init.cpp

581a71d

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

Update src/init.cpp

16901b2

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

UdjinM6 requested changes Sep 1, 2020

View reviewed changes

Minh20 and others added 8 commits September 2, 2020 09:57

Update src/init.cpp

9524808

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

Update src/dash-cli.cpp

1d433c0

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

Update src/init.cpp

57c4dc9

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

Update src/dash-cli.cpp

fe58f85

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

Update src/init.cpp

5b90fb0

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

Update src/init.cpp

20472c4

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

Update src/init.cpp

bc5d789

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

Update src/init.cpp

4918073

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

Update src/init.cpp

cf99593

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

Minh20 requested a review from UdjinM6 September 10, 2020 07:08

Minh20 closed this Sep 10, 2020

Minh20 reopened this Sep 10, 2020

Minh20 added 2 commits September 15, 2020 09:55

Merge remote-tracking branch 'origin/alphabetize' into alphabetize

0a529cf

Auto stash before merge of "alphabetize" and "origin/alphabetize"

0edae12

Revert "Auto stash before merge of "alphabetize" and "origin/alphabet…

44d3a8a

…ize"" This reverts commit 0edae12.

Minh20 added 2 commits September 21, 2020 10:28

Changes for 769f08f

854560d

changes for bc2ac58

08b7f35

UdjinM6 approved these changes Sep 23, 2020

View reviewed changes

UdjinM6 added this to the 17 milestone Sep 23, 2020

PastaPastaPasta approved these changes Sep 24, 2020

View reviewed changes

UdjinM6 merged commit 465ecee into dashpay:develop Sep 24, 2020

docs: Properly alphabetize output of CLI --help option (backport 12331) #3681

docs: Properly alphabetize output of CLI --help option (backport 12331) #3681

Minh20 commented Aug 30, 2020

PastaPastaPasta commented Aug 30, 2020

Minh20 commented Aug 30, 2020

PastaPastaPasta commented Aug 31, 2020

UdjinM6 commented Sep 3, 2020

UdjinM6 commented Sep 10, 2020

PastaPastaPasta commented Sep 16, 2020

PastaPastaPasta commented Sep 20, 2020

UdjinM6 left a comment

PastaPastaPasta left a comment

docs: Properly alphabetize output of CLI --help option (backport 12331) #3681

docs: Properly alphabetize output of CLI --help option (backport 12331) #3681

Conversation

Minh20 commented Aug 30, 2020

PastaPastaPasta commented Aug 30, 2020

Minh20 commented Aug 30, 2020

PastaPastaPasta commented Aug 31, 2020

UdjinM6 commented Sep 3, 2020

UdjinM6 commented Sep 10, 2020

PastaPastaPasta commented Sep 16, 2020

PastaPastaPasta commented Sep 20, 2020

UdjinM6 left a comment

Choose a reason for hiding this comment

PastaPastaPasta left a comment

Choose a reason for hiding this comment