Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

governance: Implement reduced governance fee #4241

Merged
merged 5 commits into from Nov 1, 2021

Conversation

PastaPastaPasta
Copy link
Member

Inspired by https://www.dashcentral.org/p/reduce-the-proposal-fee-to-one-dash

TODO:

  • Test governance objects before and after hardfork
  • Adjust timestamps HF timing for release
  • Consider implications of a node with HF active broadcasting a governance proposal object with 1 Dash fee to a network that is segmented. IE half of network has the block that activates HF, half doesn't. Since this validation appears to only happen when the collateral transaction is included in a block, and we use that block as our reference point, the result should be deterministic

@PastaPastaPasta PastaPastaPasta added this to In progress in [WIP] Backlog Jul 21, 2021
@kxcd
Copy link

kxcd commented Jul 26, 2021

We passed the governance vote https://www.dashcentral.org/p/reduce-the-proposal-fee-to-one-dash happy to help with testing and will talk to Phez about documentation updates proposal generator code seems not impacted by this change, but will test as well.

src/consensus/params.h Show resolved Hide resolved
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, at least CI is happy now :)

Few suggestions re timestamps.

src/chainparams.cpp Outdated Show resolved Hide resolved
src/chainparams.cpp Outdated Show resolved Hide resolved
src/chainparams.cpp Outdated Show resolved Hide resolved
@PastaPastaPasta
Copy link
Member Author

Hmm, I think I would propose that we postpone the merging of this until hopefully after we implement the new enhanced hard forking.

@github-actions
Copy link

github-actions bot commented Sep 2, 2021

This pull request has conflicts, please rebase.

PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 21, 2021
d003110 Remove unused guard (Hennadii Stepanov)

Pull request description:

  `BITCOIN_QT_TEST` is no longer used since switching to autotools build system.

  Some historical refs:
  - dashpay#807
  - dashpay#4241

ACKs for top commit:
  practicalswift:
    utACK d003110
  promag:
    ACK d003110.
  jonasschnelli:
    Verified ACK d003110

Tree-SHA512: 1242ef7927d2dbd2e47cdb50de6ebb20e4ac427a66a37b4d4de8ca1b50581d34f818cb576fc9fdfb3e7dd7259d11812e3807da33b3357850d67548b837d5549b
kwvg pushed a commit to kwvg/dash that referenced this pull request Oct 12, 2021
d003110 Remove unused guard (Hennadii Stepanov)

Pull request description:

  `BITCOIN_QT_TEST` is no longer used since switching to autotools build system.

  Some historical refs:
  - dashpay#807
  - dashpay#4241

ACKs for top commit:
  practicalswift:
    utACK d003110
  promag:
    ACK d003110.
  jonasschnelli:
    Verified ACK d003110

Tree-SHA512: 1242ef7927d2dbd2e47cdb50de6ebb20e4ac427a66a37b4d4de8ca1b50581d34f818cb576fc9fdfb3e7dd7259d11812e3807da33b3357850d67548b837d5549b
@PastaPastaPasta PastaPastaPasta added this to the 18 milestone Oct 15, 2021
@PastaPastaPasta PastaPastaPasta marked this pull request as ready for review October 23, 2021 03:45
@PastaPastaPasta PastaPastaPasta changed the title [WIP] governance: Implement reduced governance fee governance: Implement reduced governance fee Oct 23, 2021
@@ -216,6 +217,15 @@ class CMainParams : public CChainParams {
consensus.vDeployments[Consensus::DEPLOYMENT_DIP0020].nThresholdMin = 2420; // 60% of 4032
consensus.vDeployments[Consensus::DEPLOYMENT_DIP0020].nFalloffCoeff = 5; // this corresponds to 10 periods

// Deployment of decreased proposal fee
consensus.vDeployments[Consensus::DEPLOYMENT_GOV_FEE].bit = 7;
consensus.vDeployments[Consensus::DEPLOYMENT_GOV_FEE].nStartTime = calculate_timestamp(2021, MONTH::DEC, 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, now I'm going to have to convert this to a unix timestamp so I can make some sense out of it. :trollface:
You kids with your fancy ways of tracking time 🙄

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a07ae55 feels a bit out of scope tbh, would prefer it as a separate PR

@PastaPastaPasta
Copy link
Member Author

Dropped, please review

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timestamps are 12h off I think

src/chainparams.cpp Outdated Show resolved Hide resolved
src/chainparams.cpp Outdated Show resolved Hide resolved
@PastaPastaPasta
Copy link
Member Author

If only we had some compile time function to calculate timestamps for us... Hmm, maybe an idea for another PR. changes applied

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit 2204c85 into dashpay:develop Nov 1, 2021
@PastaPastaPasta PastaPastaPasta deleted the gov-hf-new-fee branch November 1, 2021 18:02
pravblockc pushed a commit to pravblockc/dash that referenced this pull request Nov 18, 2021
* Implement hf for reduced governance fee

Signed-off-by: pasta <pasta@dashboost.org>

* update VersionBitsDeploymentInfo

* Adjust activation times for gov fee hard fork

* Use raw timestamps

* Adjust timestamps

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Nov 7, 2023
* Implement hf for reduced governance fee

Signed-off-by: pasta <pasta@dashboost.org>

* update VersionBitsDeploymentInfo

* Adjust activation times for gov fee hard fork

* Use raw timestamps

* Adjust timestamps

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Nov 11, 2023
d003110 Remove unused guard (Hennadii Stepanov)

Pull request description:

  `BITCOIN_QT_TEST` is no longer used since switching to autotools build system.

  Some historical refs:
  - dashpay#807
  - dashpay#4241

ACKs for top commit:
  practicalswift:
    utACK d003110
  promag:
    ACK d003110.
  jonasschnelli:
    Verified ACK d003110

Tree-SHA512: 1242ef7927d2dbd2e47cdb50de6ebb20e4ac427a66a37b4d4de8ca1b50581d34f818cb576fc9fdfb3e7dd7259d11812e3807da33b3357850d67548b837d5549b
gades pushed a commit to piratecash/pirate that referenced this pull request Dec 9, 2023
* Implement hf for reduced governance fee

Signed-off-by: pasta <pasta@dashboost.org>

* update VersionBitsDeploymentInfo

* Adjust activation times for gov fee hard fork

* Use raw timestamps

* Adjust timestamps

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
gades pushed a commit to piratecash/pirate that referenced this pull request Dec 9, 2023
d003110 Remove unused guard (Hennadii Stepanov)

Pull request description:

  `BITCOIN_QT_TEST` is no longer used since switching to autotools build system.

  Some historical refs:
  - dashpay#807
  - dashpay#4241

ACKs for top commit:
  practicalswift:
    utACK d003110
  promag:
    ACK d003110.
  jonasschnelli:
    Verified ACK d003110

Tree-SHA512: 1242ef7927d2dbd2e47cdb50de6ebb20e4ac427a66a37b4d4de8ca1b50581d34f818cb576fc9fdfb3e7dd7259d11812e3807da33b3357850d67548b837d5549b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
[WIP] Backlog
In progress
Development

Successfully merging this pull request may close these issues.

None yet

4 participants